docs(agent): align monorepo product-card labels with live taxonomy - #2488
docs(agent): align monorepo product-card labels with live taxonomy#2488cursor[bot] wants to merge 4 commits into
Conversation
> 🤖 Generated by the Daily AI Engineer (Cursor cloud instance) Co-authored-by: Nikolai Emil Damm <devantler@users.noreply.github.com>
Replace nonexistent ci with github_actions, drop agentic-workflows, add roadmap, and pin the allowlist in the product-value contract test. Fixes #2260 Co-authored-by: Nikolai Emil Damm <devantler@users.noreply.github.com>
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 30c89010de
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| grep -Fq '`github_actions`' <<<"${labels_line}" || | ||
| fail "site card Labels allowlist missing live github_actions (#2260)" | ||
| grep -Fq '`roadmap`' <<<"${labels_line}" || | ||
| fail "site card Labels allowlist missing live roadmap (#2260)" |
There was a problem hiding this comment.
Validate every allowed label against the taxonomy
When a future edit adds any other nonexistent or misspelled label, this test still passes because it only requires two labels and rejects two specific retired names; for example, adding github-action leaves every assertion green even though agents will silently fail to apply it. Parse every backticked label and compare the complete set with the expected or live taxonomy so the new subset invariant is actually enforced.
AGENTS.md reference: AGENTS.md:L2413-L2418
Useful? React with 👍 / 👎.
Codex P2 assessed: VALID — and dead-ended here (#2484)The finding holds on its merits. The new block asserts that the allowlist contains A guard that passes on the defect it names is the fail-open class this repo keeps re-learning, so this is worth fixing rather than waving through. The fix is to parse every backticked label out of the allowlist line and compare the complete set against the expected taxonomy, so an unknown name fails regardless of which one it is. Unpushable from any sibling lane ( Lane data point for #2484 — five |
Codex P2 on #2488: parse every backticked Labels allowlist token and assert it is in the pinned live taxonomy so misspellings fail closed. Co-authored-by: ned <ned@devantler.tech>
Local handoff evaluation — blocked at exact head
|
Why
The monorepo product card still listed
ciandagentic-workflowslabels that do not exist on the live repo, so agents applying those names would fail triage silently.What
Updates the product-card Labels allowlist to match live taxonomy (
github_actions,roadmap) and pins the contract so invented label names cannot regress.Fixes #2260