Skip to content

fix(velero): isolate kopia repository password #2735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
devantler wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −2
Draft

fix(velero): isolate kopia repository password #2735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0933095
fix(velero): isolate kopia repository password
devantler Jul 18, 2026
222643b
Merge branch 'main' into codex/propose-fix-for-velero-decryption-key-…
devantler Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions k8s/bases/infrastructure/vault-config/job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -841,6 +841,9 @@ spec:
path "secret/data/infrastructure/ghcr/*" {
capabilities = ["create", "update", "read"]
}
path "secret/data/infrastructure/velero/*" {
capabilities = ["create", "update", "read"]
}
path "secret/data/apps/fleetdm/*" {
capabilities = ["create", "update", "read"]
}
Expand Down
5 changes: 3 additions & 2 deletions k8s/bases/infrastructure/vault-seed/push-secret-seed-velero-repo-credentials.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
# unrecoverable -- even if the R2 bucket is intact.
#
# This PushSecret one-way mirrors the password to OpenBao at
# infrastructure/backup/velero-repo so it survives a cluster rebuild.
# infrastructure/velero/repo so it survives a cluster rebuild without
# sharing the broadly readable backup-object credential prefix.
# OpenBao durability today comes from Velero snapshotting the openbao
# namespace (including its PVC) to R2 on the daily schedule -- the
# password lands in the off-cluster backup alongside every other
Expand Down Expand Up @@ -35,5 +36,5 @@ spec:
- match:
secretKey: repository-password
remoteRef:
remoteKey: infrastructure/backup/velero-repo
remoteKey: infrastructure/velero/repo

@devantler devantler Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Generated by the Agentic Engineer

[P1] Remove the old Vault key after copying it

Changing remoteKey makes ESO start writing the repository password at the new path, but a PushSecret does not migrate or delete the existing KV-v2 entry at infrastructure/backup/velero-repo. On the existing production OpenBao instance, that old entry therefore remains readable through the broad infra-backup-readonly policy, so the backup decryption key is still exposed to the audience this change intends to remove. Add an explicit one-time migration that verifies the new copy and then permanently removes the old key's versions and metadata before treating the isolation as complete.

Reviewed at 222643b4c550cb8683be77aa36d60c6543cc541f.

property: repository-password
Loading