fix: write Windows config to ProgramData and reseed per-user trays - #619
fix: write Windows config to ProgramData and reseed per-user trays#619madhavilosetty-intel wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Windows NSIS installer/uninstaller for the Console to seed configuration from a machine-wide location (%ProgramData%) so each user’s system tray can re-seed from a common config, and to more aggressively clear per-user state during reinstall/uninstall flows.
Changes:
- Write the generated
config.ymlto%ProgramData%\device-management-toolkit\config.ymlviaSetShellVarContext all. - On install/reinstall, delete each profile’s per-user
config.ymlso trays will re-seed from the machine config. - On uninstall (when opting in), remove per-user data directories for every profile, and remove the machine-wide config seed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
77d3504 to
c2c6ab6
Compare
Write the machine config to %ProgramData% (the console's Windows machineConfigPath) so each user's tray seeds from it, clear stale per-user config on (re)install, and remove every profile's per-user data on uninstall.
c2c6ab6 to
a7791f4
Compare
|
I've tested this on Windows 11, and everything looks good from my testing. Here's what I verified:
A couple of items that might be worth considering for a future enhancement (perhaps Q3'26):
Other than that, great job getting this done! |
|
@madhavilosetty-intel : I have you tried your PR by building the installer locally as well as through the https://github.com/device-management-toolkit/deployment/actions/workflows/installer-windows.yml workflow. In both the installers, after installation I am seeing that when I click the "DMT Console.lnk" the "command window" does not get launched and it closes of immediately. Could you please check I see this error "2026/07/10 16:01:21 Config error: mkdir C:\Program Files\Device Management Toolkit\Console\config: Access is denied. |
There was a problem hiding this comment.
Though not related to this PR, but there are issues in the deployment repo which needs to be fixed before any installed related merges are done:
The console sub-module and sample-ui sub-module in deployment repo does not point a commit from the main of the console and sample-ui repo, instead it point a branch created by mike
console: GitHub - device-management-toolkit/console at 9827f1807d419de476e26156408f337dd3846986 .
sample-ui: ci: ensures UI is present for building by rsdmike · Pull Request #593 · device-management-toolkit/de…
I do see following key issues in the branch which was committed through the PR# ci: ensures UI is present for building by rsdmike · Pull Request #593 · device-management-toolkit/de…
- There's a docs folder for the design in this repo, this is against the guideline which Mike had mentioned to not have design docs in the code repos.
- There are partial code changes related to the feature "Make rpc-go and config Downloadable from Console UI"
Write the machine config to %ProgramData% (the console's Windows machineConfigPath) so each user's tray seeds from it, clear stale per-user config on (re)install, and remove every profile's per-user data on uninstall.