Skip to content

#1: Added Layer rules L1-L12 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hohwille merged 5 commits into from
Feb 6, 2023
+14 −9
Merged

#1: Added Layer rules L1-L12 #10

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c647d35
Added Architecture Layer Rules 1-12.
vlad961 Jan 22, 2023
7d21655
refactoring + detailed LayerDependencyRulesTest
vlad961 Jan 24, 2023
0c97565
delete redundant layer rules check.
vlad961 Jan 30, 2023
26f82b7
Refactoring: deleted comments for better readability
vlad961 Jan 31, 2023
6f75cf6
Deleted the common layer rule.
vlad961 Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions src/test/java/com/devonfw/sample/archunit/ArchitectureTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,23 @@ public class ArchitectureTest {

@ArchTest
private static final ArchRule shouldOnlyAccessValidLayers = //
layeredArchitecture().consideringAllDependencies() //
.layer("common").definedBy("..common..") //
.layer("logic").definedBy("..logic..") //
.layer("dataaccess").definedBy("..dataaccess..") //
.layer("service").definedBy("..service..") //
.layer("batch").definedBy("..batch..") //
.layer("ui").definedBy("..ui..") //
// TODO
.because("Dependency of technical layers violates architecture rules.");
layeredArchitecture().consideringAllDependencies() //
.layer("common").definedBy("..common..") //
.layer("logic").definedBy("..logic..") //
.layer("dataaccess").definedBy("..dataaccess..") //
.layer("service").definedBy("..service..") //
.layer("client").definedBy("..client..")
.layer("batch").definedBy("..batch..")

.whereLayer("client").mayNotBeAccessedByAnyLayer()
.whereLayer("batch").mayOnlyBeAccessedByLayers( "logic")
Comment thread
hohwille marked this conversation as resolved.
Outdated
.whereLayer("service").mayOnlyBeAccessedByLayers("client")
.whereLayer("logic").mayOnlyBeAccessedByLayers("service", "batch")
.whereLayer("dataaccess").mayOnlyBeAccessedByLayers("logic")
.whereLayer("common").mayOnlyBeAccessedByLayers("common", "dataaccess", "logic", "service")
Comment thread
hohwille marked this conversation as resolved.
Outdated

.withOptionalLayers(true)
.because("Dependency of technical layers violates architecture rules.");
// ...

}