#1881 implement cdk url updater#1883
Conversation
Coverage Report for CI Build 25307819546Coverage increased (+0.03%) to 70.676%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions15 previously-covered lines in 1 file lost coverage.
Coverage Stats💛 - Coveralls |
| } | ||
|
|
||
| @Override | ||
| public String getCpeVendor() { |
There was a problem hiding this comment.
It seems like the cdk:cdk (vendor:product) doesn't exist. I've found this CVE which is related to the aws-cdk-cli tool but mapped to the CPE: cpe:2.3:a:amazon:aws_cloud_development_kit::::::::. I couldn't find any direct match for a cpe. We should discuss if we should leave the two CPE related methods empty.
MarvMa
left a comment
There was a problem hiding this comment.
I tested the UrlUpdater functionality and it worked as expected 👍 The only small thing i found is the CPE vendor and product don't exist. This is a common problem and we should discuss how to handle this.
|
@MarvMa thanks for the review. |
This PR fixes #1881
Implemented changes:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal