Skip to content

#1881 implement cdk url updater#1883

Closed
AdemZarrouki wants to merge 4 commits intodevonfw:mainfrom
AdemZarrouki:feature/1881-cdk-url-updater
Closed

#1881 implement cdk url updater#1883
AdemZarrouki wants to merge 4 commits intodevonfw:mainfrom
AdemZarrouki:feature/1881-cdk-url-updater

Conversation

@AdemZarrouki
Copy link
Copy Markdown
Contributor

@AdemZarrouki AdemZarrouki commented Apr 30, 2026

This PR fixes #1881

Implemented changes:

  • Added CdkUrlUpdater using NpmBasedUrlUpdater

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 30, 2026

Coverage Report for CI Build 25307819546

Coverage increased (+0.03%) to 70.676%

Details

  • Coverage increased (+0.03%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 15 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

15 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/url/updater/UpdateManager.java 15 0.0%

Coverage Stats

Coverage Status
Relevant Lines: 15352
Covered Lines: 11307
Line Coverage: 73.65%
Relevant Branches: 6848
Covered Branches: 4383
Branch Coverage: 64.0%
Branches in Coverage %: Yes
Coverage Strength: 3.11 hits per line

💛 - Coveralls

@AdemZarrouki AdemZarrouki marked this pull request as ready for review April 30, 2026 10:36
@AdemZarrouki AdemZarrouki self-assigned this Apr 30, 2026
@AdemZarrouki AdemZarrouki moved this from 🆕 New to Team Review in IDEasy board Apr 30, 2026
@MarvMa MarvMa self-assigned this Apr 30, 2026
}

@Override
public String getCpeVendor() {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the cdk:cdk (vendor:product) doesn't exist. I've found this CVE which is related to the aws-cdk-cli tool but mapped to the CPE: cpe:2.3:a:amazon:aws_cloud_development_kit::::::::. I couldn't find any direct match for a cpe. We should discuss if we should leave the two CPE related methods empty.

https://nvd.nist.gov/vuln/detail/CVE-2025-2598

Copy link
Copy Markdown
Contributor

@MarvMa MarvMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the UrlUpdater functionality and it worked as expected 👍 The only small thing i found is the CPE vendor and product don't exist. This is a common problem and we should discuss how to handle this.

@AdemZarrouki
Copy link
Copy Markdown
Contributor Author

@MarvMa thanks for the review.
In the daily today @hohwille explained to us that we don't need an UrlUpdater for NpmBasedCommandlet, which is the case here. For more context you can see #1860 (comment).
That's why this task is not required anymore and we can procced directly with creating the cdk commandlet.

@github-project-automation github-project-automation Bot moved this from Team Review to ✅ Done in IDEasy board May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Create CdkUrlUpdater

3 participants