Skip to content

#1882 add aws cdk commandlet#1887

Open
AdemZarrouki wants to merge 3 commits intodevonfw:mainfrom
AdemZarrouki:feature/1882-add-aws-cdk-commandlet
Open

#1882 add aws cdk commandlet#1887
AdemZarrouki wants to merge 3 commits intodevonfw:mainfrom
AdemZarrouki:feature/1882-add-aws-cdk-commandlet

Conversation

@AdemZarrouki
Copy link
Copy Markdown
Contributor

@AdemZarrouki AdemZarrouki commented May 4, 2026

This PR fixes #1882

Implemented changes:

  • Added Cdk commandlet
  • Added test suite with install and run tests
  • Added help texts, license information, and test suite
  • Added CHANGELOG entry for the new feature

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

Checklist for tool commandlets

Have you added a new «tool» as commandlet? There are the following additional checks:

  • The tool can be installed automatically (during setup via settings) or via the commandlet call
  • The tool is isolated in its IDEasy project, see Sandbox Principle
  • The new tool is added to the table of tools in LICENSE.asciidoc
  • The new commandlet is a command-wrapper for «tool»
  • Proper help texts for all supported languages are added here
  • The new commandlet installs potential dependencies automatically
  • The variables «TOOL»_VERSION and «TOOL»_EDITION are honored by your commandlet
  • The new commandlet is tested on all platforms it is available for or tested on all platforms that are in scope of the linked issue

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board May 4, 2026
@AdemZarrouki AdemZarrouki marked this pull request as ready for review May 4, 2026 13:39
@AdemZarrouki AdemZarrouki self-assigned this May 4, 2026
@AdemZarrouki AdemZarrouki moved this from 🆕 New to Team Review in IDEasy board May 4, 2026
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented May 4, 2026

Coverage Report for CI Build 25377387294

Coverage increased (+0.02%) to 70.743%

Details

  • Coverage increased (+0.02%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 8 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

8 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/commandlet/CommandletManagerImpl.java 8 90.4%

Coverage Stats

Coverage Status
Relevant Lines: 15407
Covered Lines: 11360
Line Coverage: 73.73%
Relevant Branches: 6878
Covered Branches: 4405
Branch Coverage: 64.04%
Branches in Coverage %: Yes
Coverage Strength: 3.12 hits per line

💛 - Coveralls

@AdemZarrouki AdemZarrouki force-pushed the feature/1882-add-aws-cdk-commandlet branch 2 times, most recently from 08a92d2 to 1c3796f Compare May 5, 2026 11:43
@AdemZarrouki
Copy link
Copy Markdown
Contributor Author

The build will fail because Cdk is based on NpmBasedCommandlet and if we delete the dependencies.json then we encounter an infinite loops because of cyclic dependencies between node and npm (see #1860 (comment)). The PR 1860 will fix the issue and the suggestion is first to merge it before merging this PR.

# Conflicts:
#	CHANGELOG.adoc
#	cli/src/main/java/com/devonfw/tools/ide/commandlet/CommandletManagerImpl.java
#	documentation/LICENSE.adoc
@AdemZarrouki AdemZarrouki force-pushed the feature/1882-add-aws-cdk-commandlet branch from 79fa99a to ebea40a Compare May 5, 2026 12:50
@AdemZarrouki
Copy link
Copy Markdown
Contributor Author

The PR 1860 was merged and now the tests works fine and the build was Successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Team Review

Development

Successfully merging this pull request may close these issues.

Create AWS CDK commandlet

3 participants