Skip to content

#1870: Add generic get-version implementation for global tools under windows#1896

Open
jakozian wants to merge 31 commits intodevonfw:mainfrom
jakozian:feature/#1870-generic-get-version-implementation-global-tools-windows
Open

#1870: Add generic get-version implementation for global tools under windows#1896
jakozian wants to merge 31 commits intodevonfw:mainfrom
jakozian:feature/#1870-generic-get-version-implementation-global-tools-windows

Conversation

@jakozian
Copy link
Copy Markdown
Contributor

@jakozian jakozian commented May 6, 2026

This PR fixes #1870

Implemented changes:

  • Add logic in getInstalledVersion of GlobalToolCommandlet to look up tool in Windows registry.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

jakozian and others added 26 commits April 28, 2026 09:09
Co-authored-by: MarvMa <marvin.meitzner@gmail.com>
…-tool' of https://github.com/jakozian/IDEasy into feature/devonfw#1870-generic-get-version-implementation-global-tools-windows
…tarts' of https://github.com/jakozian/IDEasy into feature/devonfw#1870-generic-get-version-implementation-global-tools-windows

# Conflicts:
#	CHANGELOG.adoc
…indows-registry' of https://github.com/jakozian/IDEasy into feature/devonfw#1870-generic-get-version-implementation-global-tools-windows
…indows-registry' into feature/devonfw#1870-generic-get-version-implementation-global-tools-windows
@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board May 6, 2026
@jakozian jakozian self-assigned this May 6, 2026
@jakozian jakozian added the windows specific for Microsoft Windows OS label May 6, 2026
@jakozian jakozian added the commandlet ide sub-command label May 6, 2026
@jakozian jakozian moved this from 🆕 New to 🏗 In progress in IDEasy board May 6, 2026
…indows-registry' of https://github.com/jakozian/IDEasy into feature/devonfw#1870-generic-get-version-implementation-global-tools-windows
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented May 6, 2026

Coverage Report for CI Build 25493800041

Coverage decreased (-0.1%) to 70.635%

Details

  • Coverage decreased (-0.1%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 82 coverage regressions across 3 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

82 previously-covered lines in 3 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/tool/GlobalToolCommandlet.java 36 2.19%
com/devonfw/tools/ide/tool/pgadmin/PgAdmin.java 27 4.76%
com/devonfw/tools/ide/os/WindowsHelperImpl.java 19 61.76%

Coverage Stats

Coverage Status
Relevant Lines: 15446
Covered Lines: 11374
Line Coverage: 73.64%
Relevant Branches: 6904
Covered Branches: 4413
Branch Coverage: 63.92%
Branches in Coverage %: Yes
Coverage Strength: 3.12 hits per line

💛 - Coveralls

@jakozian
Copy link
Copy Markdown
Contributor Author

jakozian commented May 6, 2026

Waiting for #1876 to get merged.

@jakozian jakozian marked this pull request as ready for review May 7, 2026 07:50
@jakozian jakozian moved this from 🏗 In progress to Team Review in IDEasy board May 7, 2026
@MarvMa MarvMa self-assigned this May 7, 2026
@jakozian jakozian changed the title #1870: Implement generic get-version implementation for global tools under windows #1870: Add generic get-version implementation for global tools under windows May 7, 2026
@jakozian jakozian moved this from Team Review to 👀 In review in IDEasy board May 7, 2026
@jakozian jakozian requested a review from hohwille May 7, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commandlet ide sub-command windows specific for Microsoft Windows OS

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

Implement generic get-version implementation for global tools under windows

4 participants