Skip to content

Move grpc-netty dependency to Test scope #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pancho-bo wants to merge 2 commits into
base: series/2.x
Choose a base branch
from
Open

Move grpc-netty dependency to Test scope #181

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
209851f
Move grpc-netty dependency to Test scope
pancho-bo Apr 28, 2026
a3b3e60
Examples project need grpc-netty at runtime
pancho-bo Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ lazy val grpcProtocol = project
"com.thesamet.scalapb" %% "scalapb-runtime" % scalapb.compiler.Version.scalapbVersion % "protobuf",
"com.thesamet.scalapb" %% "scalapb-runtime-grpc" % scalapb.compiler.Version.scalapbVersion,
"com.thesamet.scalapb.zio-grpc" %% "zio-grpc-core" % zioGrpcVersion,
"io.grpc" % "grpc-netty" % grpcNettyVersion
"io.grpc" % "grpc-netty" % grpcNettyVersion % Test
)
)

Expand All @@ -187,7 +187,7 @@ lazy val examples = project
"dev.zio" %% "zio-streams" % zioVersion
)
)
.dependsOn(manager, storageRedis, grpcProtocol, serializationKryo)
.dependsOn(manager, storageRedis, grpcProtocol % "compile->compile;test->test", serializationKryo)

@ghostdogpr ghostdogpr Apr 28, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples project won't work without grpc-netty

@ghostdogpr ghostdogpr Apr 28, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But also for people using Shardcake I don't really want them to care about it, so I think it's okay to ship with a default implementation.


lazy val benchmarks = project
.in(file("benchmarks"))
Expand Down