feat: add pending-signatures queue for automated deposit flow#175
Merged
feat: add pending-signatures queue for automated deposit flow#175
Conversation
2 tasks
lpahlavi
force-pushed
the
lpahlavi/defi-2780-pending-signatures-queue
branch
from
e1c1ba3 to
7476c0a
Compare
lpahlavi
changed the base branch from
main
to
lpahlavi/defi-2780-insertion-ordered-set
Replace `monitored_accounts: BTreeSet<Account>` with a new `InsertionOrderedSet<Account>` that preserves insertion order. The set is backed by `InsertionOrderedMap<K, ()>` and exposes only the methods needed at call sites: `insert`, `remove`, `contains`, `len`, and `iter`. Call sites in `deposit::automatic` are unchanged because `InsertionOrderedSet` intentionally mirrors `BTreeSet`'s API. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
- Add module-level `PENDING_SIGNATURES` thread-local to buffer discovered transaction signatures per account - Fill in `poll_account`'s signature arm: filter out failed transactions and push successful signatures into the queue - Expose `pending_signatures_for` / `reset_pending_signatures` test helpers - Replace local `sig` test helper with `test_fixtures::signature` Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
lpahlavi
force-pushed
the
lpahlavi/defi-2780-insertion-ordered-set
branch
from
31bb588 to
d653a1a
Compare
lpahlavi
force-pushed
the
lpahlavi/defi-2780-pending-signatures-queue
branch
from
7476c0a to
18d4ecf
Compare
Base automatically changed from
lpahlavi/defi-2780-insertion-ordered-set
to
main
April 27, 2026 09:22
maciejdfinity
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PENDING_SIGNATURESthread-local (BTreeMap<Account, VecDeque<Signature>>) to buffer discovered transaction signatures per accountpoll_account's previously-stubOk(signatures)arm: filters out failed transactions and pushes successful signatures into the queuepending_signatures_for/reset_pending_signaturestest helperssighelper withtest_fixtures::signature🤖 Generated with Claude Code