refactor: add source field to AcceptedDeposit event#179
Open
refactor: add source field to AcceptedDeposit event#179
AcceptedDeposit event#179Conversation
3 tasks
…to AcceptedDeposit Introduces a DepositSource enum (Manual | Automatic) and a single AcceptedDeposit event at #[n(13)] that records the source of each deposit. The old AcceptedManualDeposit CBOR index (#[n(2)]) is retired; a separate one-time migration PR will migrate any stored events to the new format before this code is deployed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lpahlavi
changed the title
lpahlavi
force-pushed
the
lpahlavi/unify-accepted-deposit-event
branch
from
d8ad4e5 to
cbb9b76
Compare
lpahlavi
changed the title
AcceptedDeposit event
2 tasks
…ed-deposit-event # Conflicts: # minter/src/deposit/manual/tests.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AcceptedManualDeposit(#[n(2)]) toAcceptedDepositand adds a mandatorysource: DepositSourcefield (whereDepositSourceisManual | Automatic)AcceptedDeposit { source: Automatic }AcceptedDeposit { source: Manual }Deployment sequence
This PR is a breaking change. The one-time migration PR (#180) must be deployed first:
AcceptedManualDepositevents toAcceptedDeposit#180) →post_upgradereads oldAcceptedManualDepositevents and re-encodes them asAcceptedDeposit { source: Manual }🤖 Generated with Claude Code