feat: [DSM-103] Actual priority queue for long executions, take 2#10034
Merged
alin-at-dfinity merged 4 commits intomasterfrom Apr 28, 2026
Merged
feat: [DSM-103] Actual priority queue for long executions, take 2#10034alin-at-dfinity merged 4 commits intomasterfrom
alin-at-dfinity merged 4 commits intomasterfrom
Conversation
Instead of a binary prioritized / opportunistic flag, explicitly (record and) prioritize long executions based on number of slices executed, AP and round when the long execution started. This ensures that we don't starve low priority canisters (which may happen with bounded AP and just the right distribution across execution cores). Also switch from persisting SubnetSchedule spread across individual canister states to persisting it as part of the subnet's SystemMetadata.
* Stop populating `SystemMetadata::subnet_schedule` on "subnet B" during a split to be serialized into individual `canister.pbuf` files; it is actually being written to `system_metadata.pbuf` now. * And stop writing the `CanisterPriority` into every `canister.pbuf`, we no longer read it from there.
Contributor
Author
|
This broke I'm resubmitting it with the fix, plus necessary adjustments to other tests. |
adambratschikaye
approved these changes
Apr 28, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of a binary prioritized / opportunistic flag, explicitly (record and) prioritize long executions based on number of slices executed, AP and round when the long execution started. This ensures that we don't starve low priority canisters (which may happen with bounded AP and just the right distribution across execution cores).
Also switch from persisting
SubnetSchedulespread across individual canister states to persisting it as part of the subnet'sSystemMetadata.