Skip to content

fix: deflake //rs/tests/node:guestos_no_failed_systemd_units #10037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
basvandijk wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −1
Draft

fix: deflake //rs/tests/node:guestos_no_failed_systemd_units #10037

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ic-os/components/networking/nftables/reload_nftables.service
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,11 @@ Wants=nss-lookup.target

[Service]
Type=oneshot
# Retry the reload a few times to absorb transient failures (e.g. nss_icos
# hostname resolution hiccups, or nftables.service being momentarily
# restarting). Without a retry, a single transient failure leaves this unit
# stuck in "failed" until the orchestrator rewrites nftables.conf again,
# which only happens on content change. That is the root cause of flakiness
# in //rs/tests/node:guestos_no_failed_systemd_units.
ExecStartPre=/usr/sbin/nft flush ruleset
ExecStart=systemctl reload nftables.service
ExecStart=/bin/bash -c 'for i in 1 2 3 4 5; do systemctl reload nftables.service && exit 0; sleep 2; done; exit 1'
Loading