test(guestos_no_failed_systemd_units): log journal of failed units#10038
Merged
basvandijk merged 2 commits intomasterfrom Apr 29, 2026
Merged
test(guestos_no_failed_systemd_units): log journal of failed units#10038basvandijk merged 2 commits intomasterfrom
basvandijk merged 2 commits intomasterfrom
Conversation
When systemctl list-units --failed returns non-empty output, parse each failed unit name and fetch its journalctl logs over SSH before the assert! fails the test, to aid debugging of flaky failures.
basvandijk
changed the title
basvandijk
changed the title
Bownairo
reviewed
Apr 29, 2026
Bownairo
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
systemctl list-units --failedreturns non-empty output, parse each failed unit name and fetch its journalctl logs over SSH before theassert!fails the test, to aid debugging of flaky failures.In particular we would like to debug the failing
reload_nftables.servicethat failed this test twice on April 27th, 2026 at 12:36:36 pm and on April 23rd, 2026 at 6:28:42 pm.Note we can't rely on the logs being shipped to ElasticSearch since the test completes either too quickly for the logs to be shipped or something in the nodes fails such that shipping can't be done successfully.