Skip to content

fix: deflake //rs/tests/nested/nns_recovery:nr_broken_dfinity_node by allowing panic #10041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
basvandijk merged 3 commits into from
Apr 28, 2026
+6 −1
Merged

fix: deflake //rs/tests/nested/nns_recovery:nr_broken_dfinity_node by allowing panic #10041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0546ace
fix: deflake //rs/tests/nested/nns_recovery:nr_broken_dfinity_node by…
basvandijk Apr 28, 2026
7744cfb
fix
basvandijk Apr 28, 2026
00f6333
no need to allow this specific panic in this specific test
basvandijk Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions rs/canister_sandbox/src/replica_controller/allowed_panics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
//! This module contains panics that are allowed by default to occur in logs in system-tests.

pub(crate) fn panic_sandboxed_execution_controller_reply_channel_closed() -> ! {
panic!("Sandboxed_execution_controller reply channel closed unexpectedly")
}

pub(crate) fn panic_launcher_exited_due_to_signal(pid: u32) -> ! {
panic!(
"Error from launcher process, pid {pid} exited due to signal! In test environments (e.g., PocketIC), you can safely ignore this message."
Expand Down
3 changes: 2 additions & 1 deletion rs/canister_sandbox/src/replica_controller/sandboxed_execution_controller.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
use super::allowed_panics::panic_sandboxed_execution_controller_reply_channel_closed;
use crate::compiler_sandbox::WasmCompilerProxy;
use crate::controller_launcher_service::ControllerLauncherService;
use crate::launcher_service::LauncherService;
Expand Down Expand Up @@ -1028,7 +1029,7 @@ impl WasmExecutor for SandboxedExecutionController {
// Wait for completion.
let result = rx
.recv()
.expect("Sandboxed_execution_controller reply channel closed unexpectedly");
.unwrap_or_else(|_| panic_sandboxed_execution_controller_reply_channel_closed());
drop(wait_timer);
let _finish_timer = self
.metrics
Expand Down
Loading