lsp-server: Compatibility with lsp ==2.3.0.0#2571
Draft
rvl wants to merge 4 commits intodhall-lang:mainfrom
Draft
lsp-server: Compatibility with lsp ==2.3.0.0#2571rvl wants to merge 4 commits intodhall-lang:mainfrom
rvl wants to merge 4 commits intodhall-lang:mainfrom
Conversation
These now match the bounds given in dhall.cabal.
Collaborator
|
If you merge rvl#1 I think that will fix the build failures |
Author
|
Thanks @Gabriella439, that's merged now. About |
Collaborator
|
I wouldn't worry about it. I don't think people use those other |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change lets dhall-lsp-server build and pass unit tests with lsp-2.3.0.0.
The PR is in draft until the Hydra build works.
I've done some light testing of this build with vscodium. Type-checking and completion seem to work.