Allow responsive Iframes and make sure, Images won't break the layout#375
Open
marcshake wants to merge 1 commit intodhg:masterfrom
Open
Allow responsive Iframes and make sure, Images won't break the layout#375marcshake wants to merge 1 commit intodhg:masterfrom
marcshake wants to merge 1 commit intodhg:masterfrom
Conversation
|
Nice - does this work with various proportion media such as YouTube's 4:3 vs. 16:9 vs 21:9 and so on? |
Author
|
Not really - although you might setup several classes for ratios. .fluidMedia { 56.25 is nothing else than 9:16 * 100 - so for 4:3-ratio you might use 75% (3:4*100) etc. But I use a lot of youtube/vimeo-clips at my website (trancefish.de) and the 56.25%-ratio looks great everytime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think, Skeleton is almost perfect. Small, easy to use and everything. But when it comes to use Iframes, you're lost. This non-js-div-solution will allow to use Iframes in a responsive manor. You can even use these fluidMedia-Containers in columns etc.