[QoL] Group Gameplay settings with section headers for readability#8513
Open
morfidon wants to merge 1 commit intodiasurgical:masterfrom
Open
[QoL] Group Gameplay settings with section headers for readability#8513morfidon wants to merge 1 commit intodiasurgical:masterfrom
morfidon wants to merge 1 commit intodiasurgical:masterfrom
Conversation
Add section headers to Gameplay settings Add lightweight, non-selectable section headers and spacers to the Gameplay settings menu so related options are easier to scan. Keep the change UI-only by injecting disabled list rows while building the settings list, without changing the options model or option behavior. Also make the initial focus fall back to the first selectable option if the previously selected option is no longer visible.
Contributor
|
This looks really nice. Some suggestions:
EDIT: Alternative on 4: move the 2 settings to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #8508
Summary
Group Gameplay settings with lightweight section headers to improve readability.
This is a UI-only change implemented in
settingsmenu.cppusing disabled list items, with no changes to option behavior or the options model.Also ensure the menu falls back to the first selectable option if the previous selection is no longer visible.