Skip to content

Update mpqfs to fix DOS support#8538

Merged
AJenbo merged 5 commits intomasterfrom
DOS
Apr 8, 2026
Merged

Update mpqfs to fix DOS support#8538
AJenbo merged 5 commits intomasterfrom
DOS

Conversation

@AJenbo
Copy link
Copy Markdown
Member

@AJenbo AJenbo commented Apr 3, 2026

Fixes #8537

glebm
glebm previously approved these changes Apr 3, 2026
@StephenCWills
Copy link
Copy Markdown
Member

I don't know if _POSIX_C_SOURCE doesn't work for DJGPP because the platform isn't fully POSIX compliant or what, but fdopen appears to be declared as a compiler extension rather than a POSIX extension. So I just went ahead and enabled compiler extensions specifically for DOS.

StephenCWills
StephenCWills previously approved these changes Apr 7, 2026
@AJenbo AJenbo enabled auto-merge (squash) April 8, 2026 01:10
@AJenbo
Copy link
Copy Markdown
Member Author

AJenbo commented Apr 8, 2026

I don't know if _POSIX_C_SOURCE doesn't work for DJGPP because the platform isn't fully POSIX compliant or what, but fdopen appears to be declared as a compiler extension rather than a POSIX extension. So I just went ahead and enabled compiler extensions specifically for DOS.

Enabling the extensions did solve the reported issue, but I tried actually building things this time (the previous fix was a bit hasty) and there where some additional issues so I ended up fixing both in mpqfs anyway.

diasurgical/mpqfs@293b3a3

@AJenbo AJenbo merged commit 4900391 into master Apr 8, 2026
26 checks passed
@AJenbo AJenbo deleted the DOS branch April 8, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to compile under DOS since inclusion of mpqfs

3 participants