Open
Conversation
When generating dlvl=2 dungeons containing a staircase down to the Poisoned Water Supply, a check is missing to ensure that doneflag is not set to FALSE by the first call to DRLG_PlaceMiniSet(PWATERIN, ...). If that was the case, then a second call to DRLG_PlaceMiniSet may be made, to place L5STAIRSUP even though doneflag may have been set to FALSE. For the correct logic, cross reference against the drlg_l2 code for placing staircases using DRLG_L2PlaceMiniSet. For a PoC triggering the incorrect behaviour, see dlvl=2, seed=0x0000007B with quest=Poisoned Water Supply active.
Member
|
So technically it would be possible to get a map that can't spawn the poisoned water entrance but fits the stairs meaning the quest is active but there's no way to reach it.... I guess the townspeople will have to drink something else xD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When generating dlvl=2 dungeons containing a
staircase down to the Poisoned Water Supply,
a check is missing to ensure that doneflag
is not set to FALSE by the first call to
DRLG_PlaceMiniSet(PWATERIN, ...).
If that was the case, then a second call to
DRLG_PlaceMiniSet may be made, to place
L5STAIRSUP even though doneflag may have been
set to FALSE.
For the correct logic, cross reference against
the drlg_l2 code for placing staircases using
DRLG_L2PlaceMiniSet.
For a PoC triggering the incorrect behaviour,
see dlvl=2, seed=0x0000007B with
quest=Poisoned Water Supply active.