objects: add BUGFIX for OperateSlainHero#2297
Open
mewmew wants to merge 1 commit intodiasurgical:masterfrom
Open
objects: add BUGFIX for OperateSlainHero#2297mewmew wants to merge 1 commit intodiasurgical:masterfrom
mewmew wants to merge 1 commit intodiasurgical:masterfrom
Conversation
The sendmsg parameter is unused in OperateSlainHero, but it should be used in each item creation function to sync the item creation to connected peers. Compare the OperateSlainHero function to all other OperateFoo functions which take a sendmsg parameter, only OperateSlainHero ignores this parameter. All other functions use it to sync item generation.
Member
|
There is a decent chance that, had this quest been available in MP, he could have been made to drop a different item for each player. |
Member
|
Lot's of bugs around unsynchronized Quest events, probably why they left them disabled despite initially promising they would be functional by release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sendmsg parameter is unused in OperateSlainHero, but it should be used in each item creation function to sync the item creation to connected peers.
Compare the OperateSlainHero function to all other OperateFoo functions which take a sendmsg parameter, only OperateSlainHero ignores this parameter. All
other functions use it to sync item generation.