Skip to content

fix: make changes for conda-forge compatibility#200

Merged
sbillinge merged 5 commits intodiffpy:mainfrom
john-halloran:forge-cleanup
Apr 14, 2026
Merged

fix: make changes for conda-forge compatibility#200
sbillinge merged 5 commits intodiffpy:mainfrom
john-halloran:forge-cleanup

Conversation

@john-halloran
Copy link
Copy Markdown
Contributor

@sbillinge Thanks for your patience while I had put this off. This should be everything we talked about for 0.2.1. The one place I don't think we came to an agreement was around python version. Currently the recipe says <3.14 because we only support up to 3.13. I believe the original plan was that supporting 3.14 would come with snmf 0.3. Does that clear it up?

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 12, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.60%. Comparing base (d7586bc) to head (bce6337).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
tests/test_snmf_optimizer.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
- Coverage   77.50%   75.60%   -1.90%     
==========================================
  Files           3        3              
  Lines          40       41       +1     
==========================================
  Hits           31       31              
- Misses          9       10       +1     
Files with missing lines Coverage Δ
tests/test_snmf_optimizer.py 95.65% <66.66%> (-4.35%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge sbillinge merged commit c0def8b into diffpy:main Apr 14, 2026
6 of 7 checks passed
@sbillinge
Copy link
Copy Markdown
Contributor

lgtm

@sbillinge
Copy link
Copy Markdown
Contributor

OK, I pushed out 0.2.1-rc.0. If it builds correctly I can push out the full release and then we can try again with conda-forge.

@john-halloran john-halloran deleted the forge-cleanup branch April 14, 2026 07:15
@john-halloran
Copy link
Copy Markdown
Contributor Author

@sbillinge The local build and installation of the rc were successful. You should be able to move ahead with the release.

@sbillinge
Copy link
Copy Markdown
Contributor

ok, that went out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants