Conversation
Adds a `rustfix` aspect that consumes `.clippy.diagnostics` files produced by `rust_clippy_aspect` and applies `MachineApplicable` suggestions directly to source files. The aspect runs unsandboxed with `no-cache` to allow writing back to the workspace source tree, and only invokes the `rustfix` binary when diagnostics are present. A phony marker file is always produced so the action is valid regardless of whether any fixes were applied. ```sh bazel build --config=rustfix //... ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
rustfixaspect that consumes.clippy.diagnosticsfiles produced byrust_clippy_aspectand appliesMachineApplicablesuggestions directly to source files.The aspect runs unsandboxed with
no-cacheto allow writing back to the workspace source tree, and only invokes therustfixbinary when diagnostics are present. A phony marker file is always produced so the action is valid regardless of whether any fixes were applied.The rustfix config in .bazelrc also disables the persistent action cache via --use_action_cache=false. The no-cache tag only disables disk and remote cache — not the persistent action cache — so this flag is required to ensure stale cached actions don't suppress re-running fixes after source changes. See bazelbuild/bazel#15516.
resolves #11