Convert legacy exceptions in the script runner instead of the engine - #23286
Draft
remyhaemmerle-da wants to merge 1 commit into
Draft
Convert legacy exceptions in the script runner instead of the engine#23286remyhaemmerle-da wants to merge 1 commit into
remyhaemmerle-da wants to merge 1 commit into
Conversation
…ad of the engine Always invoke the engine with `convertLegacyExceptions = false` and perform the legacy exception -> FailureStatus conversion in the script Runner. The conversion logic (makeFailureStatus and convertLegacyException) is consolidated on Runner and reused from ScriptF.Throw, removing the duplicated implementation. Also make convertLegacyExceptions an explicit parameter (no default) and drop the now-unused Free.getResult.
remyhaemmerle-da
force-pushed
the
remy-legacy-convertion
branch
from
August 13, 2026 15:11
46ed17d to
c07b117
Compare
remyhaemmerle-da
added
the
no-release-notes
remyhaemmerle-da
marked this pull request as draft
August 13, 2026 15:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always invoke the engine with
convertLegacyExceptions = falseand perform the legacy exception ->FailureStatusconversion in the script Runner. The conversion logic is consolidated onRunnerand reused fromScriptF.Throw, removing the duplicated implementation.Also make
convertLegacyExceptionsan explicit parameter (no default) and drop the now-unusedFree.getResult.