fix: reset SignContext state on SignPDF retry to prevent XRef corruption#136
Open
ryanmiura wants to merge 1 commit into
Open
fix: reset SignContext state on SignPDF retry to prevent XRef corruption#136ryanmiura wants to merge 1 commit into
ryanmiura wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug where retrying a PDF signature (due to buffer size increase) results in a corrupted XRef table.
Changes
I've added a reset of the following fields at the beginning of the SignPDF() method in sign.go:
By resetting these fields to nil or 0 at the start of the process, we ensure that any partial work performed during a failed signing attempt (where the signature was too long) does not pollute the cross-reference table of the successful attempt.
Testing
Tested with incremental signatures and large visual appearances. The resulting PDFs are now structurally valid and can be parsed correctly by digitorus/pdf and other PDF readers without panics.
Fixes #135