fix(manipulation): detect Viser execution completion and consume plans - #3982
Merged
Conversation
TomCC7
commented
Sep 8, 2026
TomCC7
commented
Sep 8, 2026
TomCC7
commented
Sep 8, 2026
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #3982 +/- ##
==========================================
+ Coverage 77.92% 77.98% +0.05%
==========================================
Files 1399 1399
Lines 132324 132442 +118
Branches 11492 11493 +1
==========================================
+ Hits 103111 103280 +169
+ Misses 25946 25891 -55
- Partials 3267 3271 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
TomCC7
marked this pull request as ready for review
September 8, 2026 20:19
TomCC7
requested review from
Dreamsorcerer,
aclauer,
leshy,
mustafab0,
paul-nechifor and
spomichter
as code owners
September 8, 2026 20:19
Contributor
Not safe to merge until pre-start status reads handle the absent execution manager; callers can otherwise receive an exception during module startup. Findings
|
paul-nechifor
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution path
Bug fix; no tracking issue.
Problem
EXECUTINGafter a trajectory finishes because nonblocking execution never refreshes its cached status. Planning again requires manually cancelling.Solution
NONEand the module isEXECUTING.Nonecheck for the execution manager, which is initialized at startup.How to Test
drag the arms and execute the plan, see UI updates correctly when motion finishes.
AI assistance
Codex (GPT-6) wrote the fix and regression tests, ran validation, and drafted this description.
Checklist