refactor(manipulation): localize device connection configuration - #4007
Closed
TomCC7 wants to merge 30 commits into
Closed
refactor(manipulation): localize device connection configuration#4007TomCC7 wants to merge 30 commits into
TomCC7 wants to merge 30 commits into
Conversation
TomCC7
commented
Sep 8, 2026
Comment on lines
+45
to
+68
| ## Manipulator connections | ||
|
|
||
| Manipulator assemblies own their connection settings. For a single arm, pass | ||
| `--address` after the blueprint name; qualify it as `--controlcoordinator.address` | ||
| when another module also exposes an address. The value can be an IP/hostname, | ||
| CAN interface or USB selector, or serial device path, depending on the robot. | ||
|
|
||
| ```bash | ||
| dimos run coordinator-xarm7 --address 192.168.1.185 | ||
| dimos run coordinator-piper --address can0 | ||
| ``` | ||
|
|
||
| With no address, these assemblies use mock hardware. Dual xArm uses | ||
| `--left-address` and `--right-address`; mixed xArm/Piper uses `--xarm-address` and | ||
| `--piper-address`. OpenArm and dual OpenYAM use `--left-can-port` and | ||
| `--right-can-port`. Supply every endpoint for an assembly or none: partial sets, | ||
| empty values, and surrounding whitespace are errors. Connection failure stops | ||
| startup and cleans up acquired connections; it never selects mock hardware. | ||
|
|
||
| These are ordinary module config fields, so the existing configuration sources | ||
| and precedence apply. For an instance named `ControlCoordinator`, the environment | ||
| variable is `CONTROLCOORDINATOR__ADDRESS`. The existing `--simulation` behavior | ||
| and supported simulation stacks are unchanged. | ||
|
|
Member
Author
There was a problem hiding this comment.
Suggested change
| ## Manipulator connections | |
| Manipulator assemblies own their connection settings. For a single arm, pass | |
| `--address` after the blueprint name; qualify it as `--controlcoordinator.address` | |
| when another module also exposes an address. The value can be an IP/hostname, | |
| CAN interface or USB selector, or serial device path, depending on the robot. | |
| ```bash | |
| dimos run coordinator-xarm7 --address 192.168.1.185 | |
| dimos run coordinator-piper --address can0 | |
| ``` | |
| With no address, these assemblies use mock hardware. Dual xArm uses | |
| `--left-address` and `--right-address`; mixed xArm/Piper uses `--xarm-address` and | |
| `--piper-address`. OpenArm and dual OpenYAM use `--left-can-port` and | |
| `--right-can-port`. Supply every endpoint for an assembly or none: partial sets, | |
| empty values, and surrounding whitespace are errors. Connection failure stops | |
| startup and cleans up acquired connections; it never selects mock hardware. | |
| These are ordinary module config fields, so the existing configuration sources | |
| and precedence apply. For an instance named `ControlCoordinator`, the environment | |
| variable is `CONTROLCOORDINATOR__ADDRESS`. The existing `--simulation` behavior | |
| and supported simulation stacks are unchanged. |
❌ 7 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
TomCC7
commented
Sep 8, 2026
TomCC7
commented
Sep 8, 2026
Member
Author
|
should revisit after control coordinator refacotor... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution path
Problem
global_configneeds cleanupSolution
connectionconfigHow to Test
dimos run coordinator-piper --connection.address can0.AI assistance
Checklist