feat: properly handle +CGCONTRDP when ipv6 is enabled#57
Closed
nponsard wants to merge 4 commits intodiondokter:masterfrom
Closed
feat: properly handle +CGCONTRDP when ipv6 is enabled#57nponsard wants to merge 4 commits intodiondokter:masterfrom
nponsard wants to merge 4 commits intodiondokter:masterfrom
Conversation
Signed-off-by: Nils Ponsard <nils.ponsard@inria.fr>
Signed-off-by: Nils Ponsard <nils.ponsard@inria.fr>
Signed-off-by: Nils Ponsard <nils.ponsard@inria.fr>
nponsard
force-pushed
the
fix/ipv6-parsing
branch
2 times, most recently
from
8ff6ecd to
66d394f
Compare
Signed-off-by: Nils Ponsard <nils.ponsard@inria.fr>
nponsard
force-pushed
the
fix/ipv6-parsing
branch
from
66d394f to
692ba7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got access to a SIM with IPv6 connectivity, turns out the
+CGCONTRDPresponse contains two lines starting with+CGCONTRDPwhen IPv6 is used.This PR addresses that.