fix: subscriber thread never self heals after connection issue#389
Open
Mubramaj wants to merge 7 commits into
Open
fix: subscriber thread never self heals after connection issue#389Mubramaj wants to merge 7 commits into
Mubramaj wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up on #388
Before opening this PR I first tested it on my production setup that was experiencing the "Global messages" timeout issues to make sure it fixes it without any side effect.
Happened this morning and self healed correctly:
First warning message at 7:17 am
Global messages on 1 timed out, message bus is no longer functioning correctlyFollowed by another warning
stream closed in another thread subscribe failed, reconnecting in 1 second.(7:17 am as well )It self healed correctly didn't have to restart the rails app .
Closes #387