Skip to content

Ja/php8.4 support for fix empty sheetnames #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janalwin wants to merge 2 commits into
base: 4.x
Choose a base branch
from
Open

Ja/php8.4 support for fix empty sheetnames #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2e2661
if the sheet has no name, name it sheet<number>
jantuitman Jul 4, 2024
373969d
Merge branch '4.x' into JA/php8.4-support-for-fix-empty-sheetnames
janalwin Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Reader/ODS/SheetIterator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,11 @@
public function current(): Sheet
{
$escapedSheetName = $this->xmlReader->getAttribute(self::XML_ATTRIBUTE_TABLE_NAME);
if ($escapedSheetName === null) {

$escapedSheetName = "Sheet".($this->currentSheetIndex + 1);
}
\assert(null !== $escapedSheetName);

Check failure on line 141 in src/Reader/ODS/SheetIterator.php

View workflow job for this annotation

GitHub Actions / Static Analysis (8.3) 

Strict comparison using !== between null and string will always evaluate to true.

Check failure on line 141 in src/Reader/ODS/SheetIterator.php

View workflow job for this annotation

GitHub Actions / Static Analysis (8.3) 

Call to function assert() with true will always evaluate to true.
$sheetName = $this->escaper->unescape($escapedSheetName);

$isSheetActive = $this->isSheetActive($sheetName, $this->currentSheetIndex, $this->activeSheetName);
Expand Down
Loading