Fix Issue 21294 - Improve unhelpful error message with duplicate name… - #23821
Merged
Conversation
…d argument in overload set Named-argument errors (e.g. "parameter assigned twice") were only reported via checkNamedArgErrorAndReportOverload() when the symbol was an OverDeclaration (od). Plain function overloads declared in the same scope use the fd.overnext chain instead, so the hasOverloads branch in resolveFuncCall() never ran this check and fell back to the generic "none of the overloads are callable" message. Call checkNamedArgErrorAndReportOverload(fd, ...) in that branch too, since overloadApply() already supports walking fd.overnext.
dkorpel
reviewed
Sep 10, 2026
Previously 'parameter X assigned twice' (and similar named-argument binding errors) were printed as a supplemental line under 'none of the overloads of X are callable...', followed by a list of candidates. This was misleading since a duplicate named argument is invalid regardless of overload resolution. checkNamedArgErrorAndReportOverload now returns bool and reports the binding error as the primary diagnostic; callers skip the 'none of the overloads' message and candidate list when it fires.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21294