Skip to content

GHA: Minimally simplify FreeBSD job definitions - #23828

Merged
kinke merged 1 commit into
dlang:masterfrom
kinke:gha_freebsd_simplify
Sep 11, 2026
Merged

GHA: Minimally simplify FreeBSD job definitions#23828
kinke merged 1 commit into
dlang:masterfrom
kinke:gha_freebsd_simplify

Conversation

@kinke

@kinke kinke commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

As build.d nowadays defines a proper default TARGET_FREEBSD<major> version if needed:

dmd/compiler/src/build.d

Lines 1387 to 1395 in f1b316b

if (!userDflags.any!(f => f.startsWith("-version=TARGET_FREEBSD")))
{
// uname -K gives the kernel version, e.g. 1400097. The first two
// digits correspond to the major version of the OS.
immutable result = executeShell("uname -K");
if (result.status != 0 || !result.output.take(2).all!isDigit())
throw abortBuild("Failed to get the kernel version");
dflags ~= ["-version=TARGET_FREEBSD" ~ result.output[0 .. 2]];
}

As build.d nowadays defines a proper default `TARGET_FREEBSD<major>`
version if needed.
@kinke
kinke merged commit 9eab1a5 into dlang:master Sep 11, 2026
43 checks passed
@kinke
kinke deleted the gha_freebsd_simplify branch September 11, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants