Circle CI: Adapt to upcoming breaking change #23830
+7
−9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,23 @@ | ||
| version: 2.1 | ||
| jobs: | ||
| build: | ||
| working_directory: ~/dmd # the Phobos Makefile expects this dir name, not Circle's default `~/project` | ||
| machine: | ||
| image: ubuntu-2604:current | ||
| resource_class: large.gen3 | ||
| steps: | ||
|
Contributor
Author
There was a problem hiding this comment.
[And |
||
| - checkout | ||
| - run: | ||
| command: ./.circleci/run.sh install-deps | ||
| name: Install dependencies | ||
| - run: | ||
| # needs to be a separate step, s.t. `run.sh` gets updated too | ||
| command: ./.circleci/run.sh setup-repos | ||
| name: Merge with upstream + clone Phobos | ||
| - run: | ||
| command: ./.circleci/run.sh all | ||
| name: Run all | ||
| workflows: | ||
| all: | ||
| jobs: | ||
| - build | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching from a docker container to a VM enables using the Gen3 runners, which were announced as beta some weeks ago, and are now seemingly undocumented again (from the price list).
The
large.gen3class features 4 CPU cores and 16 GB of RAM, and costs 14 credits per minute (last time I saw it in the pricing list), vs. 2 cores/4 GB for the currently usedmediumdocker gen1 @ 10 credits per minute.The thing is that gen3 is at the same time also much faster per core (Zen v5 CPUs etc.) - the CI job here took 6:34 mins, whereas a recent master one took 33+ mins. So we should be easily able to 'afford' the upgrade from medium to large resource class (1.4x credits per minute, but 5x as fast); as the linked graph shows, the CPU utilization is good.