Explicit joins in Relation.join()#3868
Open
burnash wants to merge 28 commits into
Open
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
docs | 5f01e4e | Commit Preview URL Branch Preview URL |
Jun 02 2026, 04:10 PM |
rudolfix
reviewed
Apr 16, 2026
| f"'{target_dataset.dataset_name}' vs '{self._dataset.dataset_name}'" | ||
| ) | ||
| # cross-dataset filesystem not supported | ||
| if isinstance(self.sql_client, WithSchemas): |
Collaborator
There was a problem hiding this comment.
this is a good followup ticket. if we use duckdb ATTACH we will be able to join dataset on separate physical locations. ie. joining lance and HF tables will be possible
|
|
||
| # physical destination check | ||
| if target_dataset is not self._dataset: | ||
| if not self._dataset.is_same_physical_destination(target_dataset): |
Collaborator
There was a problem hiding this comment.
our physical destination check is currently half implemented:
#3758
currently FYI but we can add this to our estimations
burnash
force-pushed
the
feat/3747-explicit-joins
branch
from
0c6c278 to
390d40a
Compare
This comment has been minimized.
This comment has been minimized.
burnash
force-pushed
the
feat/3747-explicit-joins
branch
from
38633e2 to
4aff685
Compare
burnash
force-pushed
the
feat/3747-explicit-joins
branch
from
4aff685 to
07baafa
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
burnash
force-pushed
the
feat/3747-explicit-joins
branch
from
1c86bdf to
d4378f7
Compare
This comment has been minimized.
This comment has been minimized.
…ry, fixes snowflake
…bind_query, fixes snowflake" This reverts commit 5328c02.
burnash
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3747