Allow attaching to ducklake without specifying data storage location#3945
Open
cbility wants to merge 1 commit into
Open
Allow attaching to ducklake without specifying data storage location#3945cbility wants to merge 1 commit into
cbility wants to merge 1 commit into
Conversation
Data storage location only has to be specified when creating a new ducklake, see https://ducklake.select/docs/stable/duckdb/usage/connecting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Data storage location only has to be specified when creating a new ducklake, see https://ducklake.select/docs/stable/duckdb/usage/connecting. For existing ducklakes the storage location can be read from the catalog. Specifying the storage location in code also means that any change to the storage location in the catalog breaks the code.
This change removes the autogenerated data path that is inserted when a storage location is not supplied and changes the attach sql generation so that it can omit a data path if one is not supplied.
Amends existing tests so they work when storage is not specified and adds four new tests that test connecting to a ducklake without a data path for sqlite and postgres catalogs, creating a new ducklake and then attaching to it again without specifying a data path, and running dlt pipelines that create a new ducklake and then attach to it without specifying a data path.
Related Issues
Additional Context
test_ducklake_factory_instantiationwhich needs S3 credentials which I don't have.