[CI] Various CI fixes - #694
Merged
Merged
Conversation
chyunsu3
commented
Aug 26, 2026
Comment on lines
+97
to
+99
| new_col_idx = np.asarray( | ||
| rng.choice(n_features, n_features, replace=False, shuffle=True) | ||
| ) |
Collaborator
Author
There was a problem hiding this comment.
mypy is conservative and assuming int return type for rng.choice(). We explicitly annotate the return type (np.ndarray) here.
| feat_remapper = np.arange( | ||
| start=0, stop=sklearn_model.n_features_in_, dtype=np.int32 | ||
| ) | ||
| feat_remapper = np.arange(0, stop=sklearn_model.n_features_in_, dtype=np.int32) |
Collaborator
Author
There was a problem hiding this comment.
The start parameter in np.arange is now a positional-only argument. See numpy/numpy#30368 (comment)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## mainline #694 +/- ##
============================================
- Coverage 86.32% 84.39% -1.93%
============================================
Files 13 75 +62
Lines 943 6862 +5919
Branches 0 557 +557
============================================
+ Hits 814 5791 +4977
- Misses 129 1071 +942 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lcov<2.0to work around error: