Skip to content

Add missing value support in scikit-learn random forest models - #695

Open
chyunsu3 wants to merge 3 commits into
dmlc:mainlinefrom
chyunsu3:sklearn_missing_values
Open

Add missing value support in scikit-learn random forest models#695
chyunsu3 wants to merge 3 commits into
dmlc:mainlinefrom
chyunsu3:sklearn_missing_values

Conversation

@chyunsu3

@chyunsu3 chyunsu3 commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Closes #690

  • Pass in missing_go_to_left array to the model loader.
  • Add unit tests to ensure that missing values are handled correctly.

@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.97260% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.00%. Comparing base (3b2a9a3) to head (83ce732).

Files with missing lines Patch % Lines
src/c_api/sklearn.cc 28.00% 18 Missing ⚠️
src/model_loader/sklearn_bulk.cc 97.67% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           mainline     #695      +/-   ##
============================================
- Coverage     84.39%   84.00%   -0.39%     
============================================
  Files            75       75              
  Lines          6862     6903      +41     
  Branches        557      559       +2     
============================================
+ Hits           5791     5799       +8     
- Misses         1071     1104      +33     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support missing values in scikit-learn RandomForest

1 participant