Update default tree-learning parameters and training budgets#12214
Draft
RAMitchell wants to merge 4 commits into
Draft
Update default tree-learning parameters and training budgets#12214RAMitchell wants to merge 4 commits into
RAMitchell wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the default-parameter update proposed in #12131.
Changes:
eta/learning_rate:0.3 -> 0.1min_child_weight:1 -> 2subsample:1.0 -> 0.8colsample_bytree:1.0 -> 0.8max_depthat6, following the later issue discussionxgboost.train(..., num_boost_round=300)xgboost.cv(..., num_boost_round=300)xgboost.dask.train(..., num_boost_round=300)DEFAULT_N_ESTIMATORS = 300numRound=300One risk to watch in CI is test flakiness from tests that train with implicit defaults but do not set a seed. Since the new defaults enable row and column subsampling by default, any unseeded tests relying on deterministic full-sample training may need explicit seeds or explicit
subsample=1/colsample_bytree=1.Local checks:
cmake -S . -B build-cpu -DUSE_CUDA=OFF -DGOOGLE_TEST=ON -DUSE_DMLC_GTEST=ONcmake --build build-cpu --target testxgboost -j35cmake --build build-cpu --target xgboost -j35./build-cpu/testxgboost --gtest_filter=Param.*:XGBoostParameter.*:Learner.ParameterValidation:GBTree.SelectTreeMethod23 passed, 1 skipped