Skip to content

fix(runner): flush collector data on shutdown#183

Open
linkdata wants to merge 1 commit into
dnstapir:mainfrom
linkdata:fix/data-collector-shutdown-flush
Open

fix(runner): flush collector data on shutdown#183
linkdata wants to merge 1 commit into
dnstapir:mainfrom
linkdata:fix/data-collector-shutdown-flush

Conversation

@linkdata
Copy link
Copy Markdown

Summary

  • drain pending session and histogram updates after the collector stop signal
  • flush final session and histogram data before closing writer channels
  • preserve the original interval start for shutdown flushes

Tests

  • go test ./pkg/runner ./...

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 30, 2026

Warning

Rate limit exceeded

@linkdata has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 59 minutes and 39 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a8aef4fa-942f-4d0a-9099-8fcdc5b6e7bc

📥 Commits

Reviewing files that changed from the base of the PR and between b615285 and b95407b.

📒 Files selected for processing (2)
  • pkg/runner/data_collector_test.go
  • pkg/runner/runner.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 59 minutes and 39 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@linkdata
Copy link
Copy Markdown
Author

Additional context from comment files

These notes were split from the local markdown comment files and attached here because they describe this PR's change.

Shutdown Flush

  • Bug: The collector only wrote sessions and histograms on the minute ticker; pending data could be left in memory when shutdown happened before the next tick.
  • Impact: The final partial interval of session rows and well-known-domain histogram updates could be silently lost during graceful shutdown.
  • Fix: After minimiser workers stop, the collector now drains queued session/update work and flushes any accumulated session and histogram data before closing writer channels.
  • Reasoning: Graceful shutdown should preserve already accepted data even if the current collection interval is incomplete.
  • Tests: Added collector shutdown coverage that queues a session and histogram update, stops the collector, and verifies both writer channels receive flushed data.

Shutdown Partial Interval Metadata

  • Bug: Shutdown-flushed session and histogram files still derived their start time as rotationTime - 60s, even when shutdown happened partway through the current interval.
  • Impact: The final partial interval could be written with filenames and aggregate metadata that overlapped the previous minute or claimed a longer collection window than the data actually covered.
  • Fix: The collector now tracks session and histogram interval starts explicitly and carries those starts into flushed writer payloads; legacy callers still fall back to the previous one-minute calculation.
  • Reasoning: Once shutdown can flush partial intervals, the writer contract needs both interval boundaries instead of reconstructing the start from the stop time.
  • Tests: Extended collector shutdown coverage to assert flushed session and histogram payloads carry non-zero, non-inverted interval boundaries.

@linkdata linkdata marked this pull request as ready for review April 30, 2026 12:12
@linkdata linkdata requested a review from a team as a code owner April 30, 2026 12:12
@jschlyter jschlyter added the ai AI was used to write contributed code label Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai AI was used to write contributed code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants