Skip to content

fix(runner): preserve exact aggregate intervals#185

Open
linkdata wants to merge 1 commit into
dnstapir:mainfrom
linkdata:fix/aggregate-exact-interval
Open

fix(runner): preserve exact aggregate intervals#185
linkdata wants to merge 1 commit into
dnstapir:mainfrom
linkdata:fix/aggregate-exact-interval

Conversation

@linkdata
Copy link
Copy Markdown

Summary

  • preserve exact aggregate interval durations in outbound HTTP headers
  • format intervals as ISO-8601 durations instead of rounded minute counts
  • add duration and header regression coverage

Tests

  • go test ./pkg/runner ./...

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 30, 2026

Warning

Rate limit exceeded

@linkdata has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 59 minutes and 36 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d7a0ea8a-9785-4d01-b53a-d0752fc81d4e

📥 Commits

Reviewing files that changed from the base of the PR and between b615285 and 09c4ca6.

📒 Files selected for processing (2)
  • pkg/runner/aggregate_sender.go
  • pkg/runner/aggregate_sender_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 59 minutes and 36 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@linkdata
Copy link
Copy Markdown
Author

Additional context from comment files

These notes were split from the local markdown comment files and attached here because they describe this PR's change.

Exact Aggregate Intervals

  • Bug: Histogram upload metadata truncated the interval start to the minute and rounded the duration to whole minutes.
  • Impact: Partial histogram files, including shutdown flushes or any second-precision filename interval, could be reported to aggrec with the wrong Aggregate-Interval, such as a 45-second interval becoming PT1M or PT0M.
  • Fix: The sender now preserves the exact start timestamp and formats the duration as an ISO 8601 duration with second precision when needed.
  • Reasoning: The filename parser already preserves start/stop seconds, and aggrec accepts ISO 8601 start/duration intervals, so the upload metadata should reflect the file's actual interval rather than a rounded minute bucket.
  • Tests: Added duration formatting coverage and an aggregate sender test that posts to a local HTTP server and verifies the exact Aggregate-Interval header.

@linkdata linkdata marked this pull request as ready for review April 30, 2026 12:12
@linkdata linkdata requested a review from a team as a code owner April 30, 2026 12:12
@jschlyter jschlyter added the ai AI was used to write contributed code label Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai AI was used to write contributed code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants