fix(doclang): sanitize XML-illegal text characters#687
Open
AkhilTrivediX wants to merge 1 commit into
Open
Conversation
Signed-off-by: AkhilTrivediX <118957648+AkhilTrivediX@users.noreply.github.com>
Contributor
|
✅ DCO Check Passed Thanks @AkhilTrivediX, all your commits are properly signed off. 🎉 |
Contributor
Merge Protections🔴 1 of 2 protections blocking · waiting on 👀 reviews
🔴 Require two reviewer for test updatesWaiting for
This rule is failing.When test data is updated, we require two reviewers
Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves XML-illegal text characters as visible Unicode markers during DocLang serialization, preventing
parseStringfrom raising on content such as PPTX soft line breaks (\x0b).Fixes #686
Changes
[U+XXXX]so the source anomaly remains visible.Type of change
How Has This Been Tested?
uv run pytest test/test_serialization_doclang.py -k xml_illegal -quv run mypy docling_core/transforms/serializer/doclang.py test/test_serialization_doclang.pyuv run ruff check docling_core/transforms/serializer/doclang.py test/test_serialization_doclang.pyuv run ruff format --check docling_core/transforms/serializer/doclang.py test/test_serialization_doclang.pyChecklist