Skip to content

fix(odf): preserve text after space elements#3853

Closed
pablopupo wants to merge 1 commit into
docling-project:mainfrom
pablopupo:fix/3847-odf-child-tail-text
Closed

fix(odf): preserve text after space elements#3853
pablopupo wants to merge 1 commit into
docling-project:mainfrom
pablopupo:fix/3847-odf-child-tail-text

Conversation

@pablopupo

Copy link
Copy Markdown
Contributor

Text following <text:s/> is stored in the element's tail. _odf_text_runs() reads the space itself but not that tail, so the rest of the span is lost.

Use text_recursive for <text:s> and add an ODT regression test for the reported structure.

Issue resolved by this Pull Request:
Resolves #3847

Checklist:

  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • Tests have been added, if necessary.

Signed-off-by: Pablo Pupo <pablofpupo23@gmail.com>
@github-actions

Copy link
Copy Markdown
Contributor

DCO Check Passed

Thanks @pablopupo, all your commits are properly signed off. 🎉

@mergify

mergify Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 Merge protection satisfied — ready to merge.

Show 1 satisfied protection

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@dolfim-ibm

Copy link
Copy Markdown
Member

@pablopupo I think your PR is solving the same issue of #3850.

@pablopupo

Copy link
Copy Markdown
Contributor Author

Yes, #3850 covers this case and the broader inline-tail path. I missed it before opening this draft. I'll close this PR in favor of #3850.

@pablopupo pablopupo closed this Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ODF backend drops text following a <text:s/> inside a <text:span>

2 participants