fix: skip image enrichment without pages#3875
Open
DebadityaHait wants to merge 1 commit into
Open
Conversation
Signed-off-by: debaditya <debaditya2005hait@gmail.com>
Contributor
|
✅ DCO Check Passed Thanks @DebadityaHait, all your commits are properly signed off. 🎉 |
Contributor
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue resolved by this Pull Request:
Resolves #3867
Description
Skip image enrichment for native charts that have neither an embedded image nor page images, preventing
SimplePipelinefrom indexing an empty page list. The chart remains in the converted document.Checklist:
Tests:
uv run pytest tests/test_backend_pptx.py -quv run ruff format --check docling/models/base_model.py tests/test_backend_pptx.pyuv run ruff check docling/models/base_model.py tests/test_backend_pptx.py