Conversation
It tried to add EOF as -1, but EOF is checked as 256 in cooked_read(). As the result, EOF was reported as error 1, which is "invalid function".
256 is used as EOF, but it was eaten by functions with "unsigned char" return type. Change such function to return "unsigned int".
TestDrive2 returns 0 from int16, and previously we used to treat that as "no key". But EOF is more interesting, as it allows to interrupt blocking calls. TestDrive2 didn't use them, but I am going to use that for other things.
Propagate it also from Busy(), which allows to remove it from the kbd buffer immediately, rather than to leave for next read().
Checked with ms-dos for the same behavior. Note that ^Z needs no special handling: needs Enter after one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.