⚙️ FEATURE-#58: Resolve bundled provider templates by bare name - #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pycodeloop/providers/__init__.py— AddsBUNDLED_TEMPLATES, the set of template stems discovered fromproviders/templates/*.jsonat import time.get_provider()resolves a bare name in that set (e.g."anthropic","ollama") to the packaged JSON path before falling through to thePROVIDERSregistry ormodule:Classsyntax. Extracted the JSON-loading branch into_from_json_path()so both the path and bare-name cases share it.pycodeloop/cli/flow.py—resolve_provider()now treats a bundled template name the same as a.jsonpath when building kwargs, so it doesn't force-override the template's ownmodelwithSettings.MODELwhen--modelisn't passed.Motivation and Context
--providerrequired a full/relative path to a JSON template, so running the CLI from outside the repo always needed the full path topycodeloop/providers/templates/*.json. Now the bundled templates resolve by short name from anywhere the package is installed:pycodeloop --provider anthropic pycodeloop --provider ollama pycodeloop run "..." --provider openai --model gpt-5Closes #58.
Types of changes
Checklist