Skip to content

Fix CS0757 error when multi-targeting with Microsoft.Extensions.Telemetry.Abstractions #7062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fix CS0757 error when multi-targeting with Microsoft.Extensions.Telemetry.Abstractions #7062

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b8badfc
Initial plan
Copilot Nov 20, 2025
66c5eb2
Add buildTransitive files for net9.0 and net10.0
Copilot Nov 20, 2025
1a3aa11
Rename MSBuild targets to avoid conflict with Microsoft.Extensions.Lo…
Copilot Nov 20, 2025
dec1fad
Remove redundant net9.0 and net10.0 buildTransitive folders
Copilot Nov 20, 2025
25054c3
Use generic buildTransitive files for all TFMs
Copilot Nov 20, 2025
a00b32e
Merge branch 'main' into copilot/fix-telemetry-abstractions-issue
evgenyfedorov2 Nov 21, 2025
99a4472
Remove extra property
evgenyfedorov2 Dec 12, 2025
d864ca3
Restore framework-specific buildTransitive folders and add net9.0
Copilot Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions ...soft.Extensions.Telemetry.Abstractions/Microsoft.Extensions.Telemetry.Abstractions.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,29 +20,18 @@
<Stage>normal</Stage>
<MinCodeCoverage>100</MinCodeCoverage>
<MinMutationScore>100</MinMutationScore>
<!-- Disable automatic generation of TFM-specific buildTransitive files - we use generic ones instead -->
<DisableNETStandardCompatErrors>true</DisableNETStandardCompatErrors>
</PropertyGroup>

<ItemGroup>
<ProjectReference Include="..\Microsoft.Extensions.Compliance.Abstractions\Microsoft.Extensions.Compliance.Abstractions.csproj" />
</ItemGroup>

<ItemGroup>
<None Include="buildTransitive\**\*" CopyToOutputDirectory="PreserveNewest" Pack="true" PackagePath="buildTransitive\%(RecursiveDir)%(Filename)%(Extension)" />
<None Include="buildTransitive\*" CopyToOutputDirectory="PreserveNewest" Pack="true" PackagePath="buildTransitive\" />
</ItemGroup>

<!-- For net462 we automatically add package buildtransitive target files, so we need to Include
the code that will disable the Microsoft.Extensions.Logging.Abstractions source generator. -->
<PropertyGroup>
<_AdditionalNETStandardCompatErrorFileContents>
<![CDATA[
<!-- This package should replace the Microsoft.Extensions.Logging.Abstractions source generator, so we set the property to remove the source generator from the project. -->
<PropertyGroup>
<DisableMicrosoftExtensionsLoggingSourceGenerator>true</DisableMicrosoftExtensionsLoggingSourceGenerator>
</PropertyGroup>
]]>
</_AdditionalNETStandardCompatErrorFileContents>
</PropertyGroup>

<ItemGroup>
<AnalyzerReference Include="..\..\Generators\Microsoft.Gen.Logging\Microsoft.Gen.Logging.csproj" />
<AnalyzerReference Include="..\..\Generators\Microsoft.Gen.Metrics\Microsoft.Gen.Metrics.csproj" />
Expand Down
0 ...t.Extensions.Telemetry.Abstractions.props → ...t.Extensions.Telemetry.Abstractions.props
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...Extensions.Telemetry.Abstractions.targets → ...Extensions.Telemetry.Abstractions.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project>
<!-- This package should replace the "Microsoft.Extensions.Logging.Abstractions" source generator. -->
<Target Name="_Microsoft_Extensions_Logging_AbstractionsRemoveAnalyzers"
Copy link
Copy Markdown
Member

@joperezr joperezr Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that the two targets had the same name was very intentional, as we want to make sure that the targets are replaced such that only one ever runs in a project evaluation. Do we have a repro project where we can clearly see the issue? I'd like to see that to better understand the problem and validate the RCA made here, as I don't think that target naming colissions was the problem.

<Target Name="_Microsoft_Extensions_Telemetry_AbstractionsRemoveAnalyzers"
Condition="'$(DisableMicrosoftExtensionsLoggingSourceGenerator)' == 'true'"
AfterTargets="ResolveReferences">
<ItemGroup>
Expand All @@ -19,7 +19,7 @@
<!-- We have a WPF-specific target because WPF projects generate and compile a temporary project (via "GenerateTemporaryTargetAssembly" target),
and that temp project doesn't have "ResolveReferences" target we expect.
This leads to the runtime's generator not being removed and to a compile-time error CS0757. This additional target resolves the problem. -->
<Target Name="_Microsoft_Extensions_Logging_AbstractionsRemoveAnalyzersWPF"
<Target Name="_Microsoft_Extensions_Telemetry_AbstractionsRemoveAnalyzersWPF"
Condition="'$(DisableMicrosoftExtensionsLoggingSourceGenerator)' == 'true'"
AfterTargets="RemoveDuplicateAnalyzers">
<ItemGroup>
Expand Down
6 changes: 0 additions & 6 deletions ...try.Abstractions/buildTransitive/net8.0/Microsoft.Extensions.Telemetry.Abstractions.props
View file
Open in desktop

This file was deleted.

36 changes: 0 additions & 36 deletions ...y.Abstractions/buildTransitive/net8.0/Microsoft.Extensions.Telemetry.Abstractions.targets
View file
Open in desktop

This file was deleted.

Loading