Decouple IngestionDocumentReader from IngestionPipeline constructor#7454
Draft
Copilot wants to merge 1 commit intodata-ingestion-preview2from
Draft
Decouple IngestionDocumentReader from IngestionPipeline constructor#7454Copilot wants to merge 1 commit intodata-ingestion-preview2from
Copilot wants to merge 1 commit intodata-ingestion-preview2from
Conversation
…(IAsyncEnumerable<IngestionDocument>) overload Agent-Logs-Url: https://github.com/dotnet/extensions/sessions/4dc3f0c2-40aa-445e-9392-fa3e254d2d05 Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
adamsitnik
April 7, 2026 17:55
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IngestionPipeline<T>required anIngestionDocumentReaderat construction time, making it impossible to use with in-memory or programmatically created documents.Changes
IngestionPipeline<T>constructor — removedreaderparameter; pipeline now only requireschunkerandwriterProcessAsync(IAsyncEnumerable<IngestionDocument>, CancellationToken)processes documents directly without any file-system dependencyProcessAsync(IngestionDocumentReader, DirectoryInfo, ...)andProcessAsync(IngestionDocumentReader, IEnumerable<FileInfo>, ...)now takereaderas a mandatory first argumentDiagnosticsConstants— addedProcessDocuments/ProcessDocumentactivity names for the new overload's tracingCanProcessDocumentsWithoutReaderdemonstrating direct document ingestionDataIngestor.csand all 5 integration-test snapshotsMicrosoft.Extensions.DataIngestion,MarkItDown, andMarkdigdocsUsage without a reader
Usage with a reader (file system)
Microsoft Reviewers: Open in CodeFlow