Skip to content

[tests] Add a few missing warning filters. #25650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rolfbjarne wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −5
Open

[tests] Add a few missing warning filters. #25650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b84e2b0
[tests] Add a few missing warning filters.
rolfbjarne Jun 5, 2026
baa8185
[tests] Add a few missing warning filters.
rolfbjarne Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/dotnet/UnitTests/ProjectTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2400,7 +2400,7 @@ public void NoWarnCodesign (ApplePlatform platform, string runtimeIdentifiers, s
properties ["ExcludeNUnitLiteReference"] = "true";
properties ["ExcludeTouchUnitReference"] = "true";
var rv = DotNet.AssertBuild (project_path, properties);
rv.AssertNoWarnings ();
rv.AssertNoWarnings ((evt) => !Extensions.IsFilteredWarning (evt, platform));
}

[Test]
Expand Down Expand Up @@ -2652,7 +2652,7 @@ public void MultiTargetLibrary (ApplePlatform platform)

properties ["cmdline:AllTheTargetFrameworks"] = targetFrameworks;
var rv = DotNet.AssertBuild (project_path, properties);
rv.AssertNoWarnings ();
rv.AssertNoWarnings ((evt) => !Extensions.IsFilteredWarning (evt, platform));
}

// Mac Catalyst projects can't be built with an earlier version of Xcode (even library projects),
Expand Down
6 changes: 3 additions & 3 deletions tests/dotnet/UnitTests/TemplateTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ public void CreateAndBuildProjectTemplate (TemplateInfo info)
rv = DotNet.AssertBuild (proj, properties);

// There should still not be any warnings
warnings = BinLog.GetBuildLogWarnings (rv.BinLogPath).Select (v => v.Message);
warnings = BinLog.GetBuildLogWarnings (rv.BinLogPath).FilterWarnings (info.Platform).Select (v => v.Message);
Assert.That (warnings, Is.Empty, $"Build warnings (2):\n\t{string.Join ("\n\t", warnings)}");

var appPath = GetAppPath (proj, platform, runtimeIdentifiers);
Expand Down Expand Up @@ -280,7 +280,7 @@ bool IsMatching (TemplateLanguage lang, TemplateLanguage? value)
var proj = Path.Combine (outputDir, $"{info.Template}.{language.AsFileExtension ()}");
var properties = GetDefaultProperties ();
var rv = DotNet.AssertBuild (proj, properties);
var warnings = BinLog.GetBuildLogWarnings (rv.BinLogPath).Select (v => v.Message);
var warnings = BinLog.GetBuildLogWarnings (rv.BinLogPath).FilterWarnings (platform).Select (v => v.Message);
Assert.That (warnings, Is.Empty, $"Build warnings:\n\t{string.Join ("\n\t", warnings)}");

if (info.Execute) {
Expand All @@ -295,7 +295,7 @@ bool IsMatching (TemplateLanguage lang, TemplateLanguage? value)
rv = DotNet.AssertBuild (proj, properties);

// There should still not be any warnings
warnings = BinLog.GetBuildLogWarnings (rv.BinLogPath).Select (v => v.Message);
warnings = BinLog.GetBuildLogWarnings (rv.BinLogPath).FilterWarnings (platform).Select (v => v.Message);
Assert.That (warnings, Is.Empty, $"Build warnings (2):\n\t{string.Join ("\n\t", warnings)}");

var appPath = GetAppPath (proj, platform, runtimeIdentifiers);
Expand Down
Loading