Skip to content

Switch ilasm to Antlr4BuildTasks #124764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkoritzinsky merged 6 commits into from
Mar 2, 2026
Merged

Switch ilasm to Antlr4BuildTasks #124764

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eb7d27e
Switch ilasm to Antlr4BuildTasks
am11 Feb 23, 2026
59c18d7
Check in generated files to avoid Antlr's Java dep
am11 Feb 24, 2026
33b4b2a
Merge dotnet/main into feature/managed-ilasm
am11 Feb 24, 2026
6ba9d05
Implement workaround for ANTLR generated paths
am11 Feb 24, 2026
ffe585c
Merge branch 'main' into feature/managed-ilasm
am11 Feb 24, 2026
4895e03
Update generated files
am11 Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,8 @@
<MicrosoftBuildUtilitiesCoreVersion>17.11.48</MicrosoftBuildUtilitiesCoreVersion>
<DotnetSosVersion>7.0.412701</DotnetSosVersion>
<DotnetSosTargetFrameworkVersion>6.0</DotnetSosTargetFrameworkVersion>
<Antlr4CodeGeneratorVersion>4.6.6</Antlr4CodeGeneratorVersion>
<Antlr4RuntimeVersion>4.6.6</Antlr4RuntimeVersion>
<Antlr4BuildTasksVersion>12.14.0</Antlr4BuildTasksVersion>
<Antlr4RuntimeStandardVersion>4.13.1</Antlr4RuntimeStandardVersion>
<!-- Testing -->
<MicrosoftNETCoreCoreDisToolsVersion>1.6.0</MicrosoftNETCoreCoreDisToolsVersion>
<MicrosoftNETTestSdkVersion>17.4.0-preview-20220707-01</MicrosoftNETTestSdkVersion>
Expand Down
1 change: 0 additions & 1 deletion src/tools/ilasm/src/ILAssembler/GrammarVisitor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5551,7 +5551,6 @@ private static int ComputeMetadataSize(MetadataSizes sizes)
GrammarResult ICILVisitor<GrammarResult>.VisitGenericArgumentsModifier(CILParser.GenericArgumentsModifierContext context) => throw new UnreachableException(NodeShouldNeverBeDirectlyVisited);
GrammarResult ICILVisitor<GrammarResult>.VisitByRefModifier(CILParser.ByRefModifierContext context) => throw new UnreachableException(NodeShouldNeverBeDirectlyVisited);
GrammarResult ICILVisitor<GrammarResult>.VisitArrayModifier(CILParser.ArrayModifierContext context) => throw new UnreachableException(NodeShouldNeverBeDirectlyVisited);
GrammarResult ICILVisitor<GrammarResult>.VisitTypeModifiers(CILParser.TypeModifiersContext context) => throw new UnreachableException(NodeShouldNeverBeDirectlyVisited);
public GrammarResult VisitNativeTypeArrayPointerInfo(CILParser.NativeTypeArrayPointerInfoContext context) => throw new UnreachableException(NodeShouldNeverBeDirectlyVisited);
public GrammarResult VisitPointerArrayTypeSize(CILParser.PointerArrayTypeSizeContext context) => throw new UnreachableException(NodeShouldNeverBeDirectlyVisited);
public GrammarResult VisitPointerArrayTypeParamIndex(CILParser.PointerArrayTypeParamIndexContext context) => throw new UnreachableException(NodeShouldNeverBeDirectlyVisited);
Expand Down
10 changes: 8 additions & 2 deletions src/tools/ilasm/src/ILAssembler/ILAssembler.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
Expand All @@ -11,10 +11,16 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Antlr4.CodeGenerator" Version="$(Antlr4CodeGeneratorVersion)">
<PackageReference Include="Antlr4BuildTasks" Version="$(Antlr4BuildTasksVersion)">
Comment thread
am11 marked this conversation as resolved.
Outdated
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Antlr4.Runtime" Version="$(Antlr4RuntimeVersion)" />
<PackageReference Include="Antlr4.Runtime.Standard" Version="$(Antlr4RuntimeStandardVersion)" />
</ItemGroup>

<ItemGroup>
<Antlr4 Include="CIL.g4">
<Package>ILAssembler</Package>
</Antlr4>
</ItemGroup>
</Project>
Loading