Add external antlr4 project#1585
Merged
akoeplinger merged 3 commits intodotnet:mainfrom Mar 6, 2026
Merged
Conversation
Member
Author
|
/azp run source-build-reference-packages-unified-build |
|
Azure Pipelines successfully started running 1 pipeline(s). |
akoeplinger
approved these changes
Mar 2, 2026
jkoritzinsky
added a commit
to dotnet/dotnet
that referenced
this pull request
Mar 2, 2026
Added exclusions for various antlr4 runtime files to limit compliance work. Opening before we merge in dotnet/source-build-assets#1585
ellahathaway
reviewed
Mar 3, 2026
Member
ellahathaway
left a comment
ellahathaway
left a comment
There was a problem hiding this comment.
NU1101: Unable to find package Microsoft.NETFramework.ReferenceAssemblies`
On Windows, Antlr4.csproj targets net45;netstandard2.0; restoring net45 implicitly requires Microsoft.NETFramework.ReferenceAssemblies, but this build uses a generated NuGet config that clears all feeds except SBRP, where that package is not available.
Member
I think we should skip net45 as the consumer project is only targeting net11. |
am11
reviewed
Mar 6, 2026
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
akoeplinger
approved these changes
Mar 6, 2026
akoeplinger
reviewed
Mar 6, 2026
am11
approved these changes
Mar 6, 2026
This was referenced Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are adding a dependency on Antlr4.Runtime.Standard in dotnet/runtime#124764 for our new managed ilasm implementation. This PR adds the requisite logic to source-build just the Antlr4 C# runtime.
See dotnet/runtime#124764 for more info
cc: @am11