Fix ToolStripManager restore issue when ToolStripPanel padding is asymmetric - #15070
Open
KSaiSivani wants to merge 1 commit into
Open
Fix ToolStripManager restore issue when ToolStripPanel padding is asymmetric#15070KSaiSivani wants to merge 1 commit into
KSaiSivani wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15070 +/- ##
=============================================
Coverage 37.24166% 37.24166%
=============================================
Files 246 246
Lines 9774 9774
Branches 1029 1029
=============================================
Hits 3640 3640
Misses 5970 5970
Partials 164 164
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4449
Proposed changes
Corrected comparison in ToolStripPanel.MoveInsideContainer for horizontal orientation to use Padding.Top instead of Padding.Left.
Ensures row insertion logic respects asymmetric padding values consistently.
Added unit tests to validate behavior.
Customer Impact
Toolbars restored via ToolStripManager.LoadSettings now appear in the correct location when ToolStripPanel.Padding is asymmetric.
Prevents unexpected row shifts and incorrect toolbar placement, improving layout persistence reliability.
Regression?
Risk
Screenshots
Before
on load:
on save:
After
on load:
on save:
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow